Docs updates for E/A#85194 Add partial approval from Reports page#89640
Docs updates for E/A#85194 Add partial approval from Reports page#89640stephanieelliott merged 1 commit intomainfrom
Conversation
Co-authored-by: nkdengineer <nkdengineer@users.noreply.github.com>
|
@stephanieelliott looks like this was merged without a test passing. Please add a note explaining why this was done and remove the |
|
|
||
| If a report contains one or more held expenses, clicking **Approve** (from within the report or from the **Reports** page) displays a confirmation modal with two options: | ||
|
|
||
| - **Approve only [non-held amount]**: Approves only the compliant (non-held) expenses. The held expenses are moved to a separate report so they can be reviewed independently. |
There was a problem hiding this comment.
Readability / style: The word "compliant" is internal jargon that may not be clear to end users. Consider replacing "compliant (non-held)" with just "non-held" since the parenthetical already clarifies the meaning, or use plain language like "remaining" or "non-held".
Suggestion:
- **Approve only [non-held amount]**: Approves only the non-held expenses. The held expenses are moved to a separate report so they can be reviewed independently.
|
|
||
| ## What happens to held expenses when I partially approve a report? | ||
|
|
||
| When you choose **Approve only**, the held expenses are moved to a new separate report. The non-held expenses are approved on the original report. You can then review and approve the held expenses independently once they are ready. |
There was a problem hiding this comment.
Naming and style: Per naming conventions, use "Click" or "Select" for UI button interactions instead of "choose."
| When you choose **Approve only**, the held expenses are moved to a new separate report. The non-held expenses are approved on the original report. You can then review and approve the held expenses independently once they are ready. | |
| When you click **Approve only**, the held expenses are moved to a new separate report. The non-held expenses are approved on the original report. You can then review and approve the held expenses independently once they are ready. |
HelpDot Documentation ReviewOverall AssessmentThis PR adds documentation for the partial approval workflow when reports contain held expenses. It introduces one new instructional section and one new FAQ entry to the existing Approve-Expenses.md article. The changes are well-scoped, clearly written, and largely compliant with HelpDot governance standards. Scores Summary
Key Findings
Recommendations
Files Reviewed
Note: This review covers only the proposed changes in the diff, not pre-existing content in the file. |
Summary
Approve-Expenses.mdexplaining the approval modal options (approve only non-held amount vs. approve full amount)Related PR: #85194